Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] New API call in the Execution Plan to log/trace the plan #565

Merged
merged 18 commits into from
Sep 30, 2024
Merged

[API] New API call in the Execution Plan to log/trace the plan #565

merged 18 commits into from
Sep 30, 2024

Conversation

jjfumero
Copy link
Member

Description

This patch extends the API with a new method to log/dump the operations enabled for the TornadoVM execution plan.

New methods:

plan.printTraceExecutionPlan();

String s = plan.getTraceExecutionPlan()

How to use it?

// Testing multiple functions to invoke the print logic plan later
executionPlan.withWarmUp() //
      .withDevice(device) //
      .withGridScheduler(grid) //
      .withThreadInfo() //
      .withProfiler(ProfilerMode.SILENT);

// When we call execute(), then it records the path 
executionPlan.execute();

Output:

Root
 -> withWarmUp 
 -> withDevice 
 -> withGridScheduler 
 -> withThreadInfo 
 -> withProfiler

Problem description

n/a.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

tornado-test -V --fast uk.ac.manchester.tornado.unittests.executor.TestExecutor#test05
make tests

@jjfumero jjfumero added the API label Sep 27, 2024
@jjfumero jjfumero self-assigned this Sep 27, 2024
@jjfumero jjfumero changed the title [API] [API] New API call in the Execution Plan to log/trace the plan Sep 27, 2024
mikepapadim
mikepapadim reviewed Sep 27, 2024
View reviewed changes
tornado-api/src/main/java/uk/ac/manchester/tornado/api/plantype/ExecutionPlanType.java Outdated

import uk.ac.manchester.tornado.api.TornadoExecutionPlan;

public sealed class ExecutionPlanType extends TornadoExecutionPlan //
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to make the ExecutionPlan types records instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExecutionPlanType cotains mutable fields and it extends another class, so we can't.

stratika
stratika requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes suggested, thanks for the PR.

tornado-api/src/main/java/uk/ac/manchester/tornado/api/TornadoExecutionPlan.java Outdated Show resolved Hide resolved
tornado-api/src/main/java/uk/ac/manchester/tornado/api/TornadoExecutionPlan.java Outdated Show resolved Hide resolved
tornado-api/src/main/java/uk/ac/manchester/tornado/api/TornadoExecutor.java Show resolved Hide resolved
tornado-api/src/main/java/uk/ac/manchester/tornado/api/TornadoExecutor.java Show resolved Hide resolved
@jjfumero
Copy link
Member Author

Thank you @stratika , I refactored the classes.

@stratika
Copy link
Collaborator

Thank you @stratika , I refactored the classes.

perfect, I will do final testing before the approval.

stratika
stratika approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Linux OS, all backends.

@jjfumero jjfumero merged commit 4bc5417 into beehive-lab:develop Sep 30, 2024
2 checks passed
@jjfumero jjfumero deleted the feat/api/log branch September 30, 2024 07:52
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request Sep 30, 2024
@jjfumero
[release] TornadoVM 1.0.8
cd970fc 
Improvements
============
- beehive-lab#565: New API call in the Execution Plan to log/trace the executed configuration plans.
- beehive-lab#563: Expand the TornadoVM profiler with Level Zero Sysman Energy Metrics.
- beehive-lab#559: Refactoring Power Metric handlers for PTX and OpenCL.
- beehive-lab#548: Benchmarking improvements.
- beehive-lab#549: Prebuilt API tests added using multiple backend-setup.
- Add internal tests for monitoring memory management [link](beehive-lab@0644225).

Compatibility
=============
- beehive-lab#561: Build for OSx 14.6 and OSx 15 fixed.

Bug Fixes
==============
- beehive-lab#564: Jenkins configuration fixed to run KFusion per backend.
- beehive-lab#562: Warmup action from the Execution Plan fixed to run with correct internal IDs.
- beehive-lab#557: Shared Execution Plans Context fixed.
- beehive-lab#553: OpenCL compiler flags for Intel Integrated GPUs fixed.
- beehive-lab#552: Fixed runtime to select any device among multiple SPIR-V devices.
- Fixed zero extend arithmetic operations: [link](beehive-lab@ea7b602).
@jjfumero jjfumero mentioned this pull request Sep 30, 2024
Merged
8 tasks
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request Sep 30, 2024
@jjfumero
[release] TornadoVM 1.0.8
9f36e2d 
Improvements
============
- beehive-lab#565: New API call in the Execution Plan to log/trace the executed configuration plans.
- beehive-lab#563: Expand the TornadoVM profiler with Level Zero Sysman Energy Metrics.
- beehive-lab#559: Refactoring Power Metric handlers for PTX and OpenCL.
- beehive-lab#548: Benchmarking improvements.
- beehive-lab#549: Prebuilt API tests added using multiple backend-setup.
- Add internal tests for monitoring memory management [link](beehive-lab@0644225).

Compatibility
=============
- beehive-lab#561: Build for OSx 14.6 and OSx 15 fixed.

Bug Fixes
==============
- beehive-lab#564: Jenkins configuration fixed to run KFusion per backend.
- beehive-lab#562: Warmup action from the Execution Plan fixed to run with correct internal IDs.
- beehive-lab#557: Shared Execution Plans Context fixed.
- beehive-lab#553: OpenCL compiler flags for Intel Integrated GPUs fixed.
- beehive-lab#552: Fixed runtime to select any device among multiple SPIR-V devices.
- Fixed zero extend arithmetic operations: [link](beehive-lab@ea7b602).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepapadim mikepapadim mikepapadim left review comments

@mairooni mairooni mairooni approved these changes

@stratika stratika stratika approved these changes

Assignees

@jjfumero jjfumero

Labels
API
Projects
TornadoVM 1.X (Public)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjfumero @stratika @mikepapadim @mairooni