-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: support lastest terraform, v1.1.0 #117
base: develop
Are you sure you want to change the base?
Conversation
We have already done the work on our fork here: As we moved to gitlab (doe to nicer ci-support) a PullRequest will be slightly more work. |
Hey guys! Is there any extra help needed to be able to merge those changes? The support for the version 1.x would be pretty awsome ! |
At https://gitlab.com/domaindrivenarchitecture/python-terraform tf > 1 is working. But we've done more changes than just the lift to 1.0. So extra help would be very apreciated :-) We can do a mob-pr session to setup a PR - in case of interest you can contact me at michael.jerger@meissa-gmbh.de |
Sadly its not very convenient to deal with changes/PRs between github and gitlab. My main question is: does this PR contains everything you guys have added to your gitlab repo ? If the answer is no, I'm happy to make a new PR that includes more stuff, just let me know what you think is the best approach @jerger, thanks ! |
No, we've not contributed to this PR - our solution would produce conflicts. |
Thanks for your answer @jerger! I've had a look at your changes and I've created a new branch based on the content of your gitlab repo, and I also tried to resolve most of the minor differences to try to make the reunion of the two repos as easy as posisble. Here is the branch: https://github.com/Th0masL/python-terraform/tree/1.0.4-dev-dda Is there more things we need to pair on before this would eventually get merged ? |
No let's create a PR as work in progress & discuss about our changes while seeing the diffs. |
I am using python-terraform in my projects, and I found out that python-terraform lib is not supporting latest terraform, such ass v1.1.0. So I want to contribute to add terraform v1.1.0 support