Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Docker recommended ENTRYPOINT instructions for Dockerfile #47

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

ma-04
Copy link
Contributor

@ma-04 ma-04 commented Oct 25, 2024

Running the docker image was causing some issues on my end
/usr/local/bin/run-bridge.sh: line 4: $1: unbound variable
Decided to build the image and got the warning even though the build was success. And still got the same error running the docker image.

The warning from docker build

 1 warning found:
 - JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals (line 26)      
JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Dockerfile:26

Fixed/modified based on the recommendation, and the build is working fine.

@tulir tulir merged commit 6997c0f into beeper:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants