Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Commit

Permalink
Don't bother storing client IPs
Browse files Browse the repository at this point in the history
Since requests proxy via hungry the IP is masked already. Responsibility
for tracking this is no longer with synapse.
  • Loading branch information
Fizzadar committed Jan 29, 2024
1 parent 896025b commit 7210ae3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion synapse/api/auth/internal.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ async def _wrapped_get_user_by_req(
Once get_user_by_req has set up the opentracing span, this does the actual work.
"""
try:
ip_addr = request.get_client_ip_if_available()
# Beep: don't care about client IPs in synapse since hungry proxies (so IP is hungry)
ip_addr = ""
# ip_addr = request.get_client_ip_if_available()

user_agent = get_request_user_agent(request)

access_token = self.get_access_token_from_request(request)
Expand Down

0 comments on commit 7210ae3

Please sign in to comment.