Possibility to get direct rxdart stream to avoid memory leaks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
+1 |
|
This is required to cancel the old subscription when update center position or radius & can prevent high read usage on Firestore due to memory leak. |
|
@zeusbaba can you review this PR ? |
zeusbaba
approved these changes
Mar 10, 2023
just published v2.3.15 |
zeusbaba
added a commit
that referenced
this pull request
Mar 10, 2023
* provide option to listen on source location stream which doesn't cause memory leaks, [fix from this PR](#26) * upgrade dependencies https://pub.dev/packages/geoflutterfire2/changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to use the library without memory leak that is caused by not cancelling stream subscriptions for merged streams from rxdart. No breaking changes, I kept current behaviour so to not break it work users.
Basically, creating broadcast stream and cancelling it does not nothing on the stream controller which is created in rxdart: dart-lang/sdk#26686 (comment)
The other way to fix it would be extend rxdart about possibility to return stream controller, and return both, broadcast stream and controller so user have full control over what is going down the path. But this could be overkill, and requires rxdart changes (tested that solution already). But, anyway, since we need to change the geo hash center position to start listening for different region, I would suggest using stream from rxdart directly.
The only thing that above is doesn't suits is when user need to have listener in couple places (different views for instance). But this also could be done by user by have single central place of the stream consumer.