`aifc` module is deprecated (and removed in Python 3.13) #144

mgorny · 2024-06-13T15:58:05Z

This package still uses the aifc module that is deprecated since Python 3.11, and was removed in Python 3.13.

As a result, the test suite fails with 3.13.0b2:

$ tox -e py313
py313: install_deps> python -I -m pip install pytest
.pkg: _optional_hooks> python /usr/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: get_requires_for_build_sdist> python /usr/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: build_sdist> python /usr/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi
py313: install_package> python -I -m pip install --force-reinstall --no-deps /tmp/audioread/.tox/.tmp/package/2/audioread-3.0.2.tar.gz
py313: commands[0]> pytest
========================================================= test session starts =========================================================
platform linux -- Python 3.13.0b2, pytest-8.2.2, pluggy-1.5.0
cachedir: .tox/py313/.pytest_cache
rootdir: /tmp/audioread
configfile: pyproject.toml
collected 4 items                                                                                                                     

test/test_audioread.py FFFF                                                                                                     [100%]

============================================================== FAILURES ===============================================================
__________________________________________________ test_audioread_early_exit[test-1] __________________________________________________

audiofile = <conftest.AudiofileSpec object at 0x7efcb006cad0>

    def test_audioread_early_exit(audiofile):
        """Abort the read before it is completed.
    
        This test guards against regressions such as
        https://github.com/beetbox/audioread/pull/78
    
        """
>       with audioread.audio_open(audiofile.path) as a:

test/test_audioread.py:29: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:123: in audio_open
    backends = available_backends()
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:80: in available_backends
    from . import rawread
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    # This file is part of audioread.
    # Copyright 2011, Adrian Sampson.
    #
    # Permission is hereby granted, free of charge, to any person obtaining
    # a copy of this software and associated documentation files (the
    # "Software"), to deal in the Software without restriction, including
    # without limitation the rights to use, copy, modify, merge, publish,
    # distribute, sublicense, and/or sell copies of the Software, and to
    # permit persons to whom the Software is furnished to do so, subject to
    # the following conditions:
    #
    # The above copyright notice and this permission notice shall be
    # included in all copies or substantial portions of the Software.
    
    """Uses standard-library modules to read AIFF, AIFF-C, and WAV files."""
>   import aifc
E   ModuleNotFoundError: No module named 'aifc'

.tox/py313/lib/python3.13/site-packages/audioread/rawread.py:16: ModuleNotFoundError
__________________________________________________ test_audioread_early_exit[test-2] __________________________________________________

audiofile = <conftest.AudiofileSpec object at 0x7efcb001bc50>

    def test_audioread_early_exit(audiofile):
        """Abort the read before it is completed.
    
        This test guards against regressions such as
        https://github.com/beetbox/audioread/pull/78
    
        """
>       with audioread.audio_open(audiofile.path) as a:

test/test_audioread.py:29: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:123: in audio_open
    backends = available_backends()
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:80: in available_backends
    from . import rawread
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    # This file is part of audioread.
    # Copyright 2011, Adrian Sampson.
    #
    # Permission is hereby granted, free of charge, to any person obtaining
    # a copy of this software and associated documentation files (the
    # "Software"), to deal in the Software without restriction, including
    # without limitation the rights to use, copy, modify, merge, publish,
    # distribute, sublicense, and/or sell copies of the Software, and to
    # permit persons to whom the Software is furnished to do so, subject to
    # the following conditions:
    #
    # The above copyright notice and this permission notice shall be
    # included in all copies or substantial portions of the Software.
    
    """Uses standard-library modules to read AIFF, AIFF-C, and WAV files."""
>   import aifc
E   ModuleNotFoundError: No module named 'aifc'

.tox/py313/lib/python3.13/site-packages/audioread/rawread.py:16: ModuleNotFoundError
_____________________________________________________ test_audioread_full[test-1] _____________________________________________________

audiofile = <conftest.AudiofileSpec object at 0x7efcafd8c2d0>

    def test_audioread_full(audiofile):
        """Read the audio data from the file."""
>       with audioread.audio_open(audiofile.path) as a:

test/test_audioread.py:38: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:123: in audio_open
    backends = available_backends()
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:80: in available_backends
    from . import rawread
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    # This file is part of audioread.
    # Copyright 2011, Adrian Sampson.
    #
    # Permission is hereby granted, free of charge, to any person obtaining
    # a copy of this software and associated documentation files (the
    # "Software"), to deal in the Software without restriction, including
    # without limitation the rights to use, copy, modify, merge, publish,
    # distribute, sublicense, and/or sell copies of the Software, and to
    # permit persons to whom the Software is furnished to do so, subject to
    # the following conditions:
    #
    # The above copyright notice and this permission notice shall be
    # included in all copies or substantial portions of the Software.
    
    """Uses standard-library modules to read AIFF, AIFF-C, and WAV files."""
>   import aifc
E   ModuleNotFoundError: No module named 'aifc'

.tox/py313/lib/python3.13/site-packages/audioread/rawread.py:16: ModuleNotFoundError
_____________________________________________________ test_audioread_full[test-2] _____________________________________________________

audiofile = <conftest.AudiofileSpec object at 0x7efcafff7950>

    def test_audioread_full(audiofile):
        """Read the audio data from the file."""
>       with audioread.audio_open(audiofile.path) as a:

test/test_audioread.py:38: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:123: in audio_open
    backends = available_backends()
.tox/py313/lib/python3.13/site-packages/audioread/__init__.py:80: in available_backends
    from . import rawread
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    # This file is part of audioread.
    # Copyright 2011, Adrian Sampson.
    #
    # Permission is hereby granted, free of charge, to any person obtaining
    # a copy of this software and associated documentation files (the
    # "Software"), to deal in the Software without restriction, including
    # without limitation the rights to use, copy, modify, merge, publish,
    # distribute, sublicense, and/or sell copies of the Software, and to
    # permit persons to whom the Software is furnished to do so, subject to
    # the following conditions:
    #
    # The above copyright notice and this permission notice shall be
    # included in all copies or substantial portions of the Software.
    
    """Uses standard-library modules to read AIFF, AIFF-C, and WAV files."""
>   import aifc
E   ModuleNotFoundError: No module named 'aifc'

.tox/py313/lib/python3.13/site-packages/audioread/rawread.py:16: ModuleNotFoundError
======================================================= short test summary info =======================================================
FAILED test/test_audioread.py::test_audioread_early_exit[test-1] - ModuleNotFoundError: No module named 'aifc'
FAILED test/test_audioread.py::test_audioread_early_exit[test-2] - ModuleNotFoundError: No module named 'aifc'
FAILED test/test_audioread.py::test_audioread_full[test-1] - ModuleNotFoundError: No module named 'aifc'
FAILED test/test_audioread.py::test_audioread_full[test-2] - ModuleNotFoundError: No module named 'aifc'
========================================================== 4 failed in 0.08s ==========================================================
py313: exit 1 (0.38 seconds) /tmp/audioread> pytest pid=97746
.pkg: _exit> python /usr/lib/python3.12/site-packages/pyproject_api/_backend.py True flit_core.buildapi
  py313: FAIL code 1 (5.46=setup[5.08]+cmd[0.38] seconds)
  evaluation failed :( (5.57 seconds)

Python 3.13 no longer includes `aifc` in standard libraries https://docs.python.org/3.13/whatsnew/3.13.html#whatsnew313-pep594 This is still used by audioread, a dependency of pyacousticid beetbox/audioread#144

lucas42 · 2024-10-14T20:29:41Z

It's worth mentioning that the sunau module is also deprecated and being removed at the same time.
(There was discussion about wave, but looks like they'd decided to keep it in python core)

There's an attempt to make the deprecated libraries available as pip dependencies: https://github.com/youknowone/python-deadlib However, it seems there's currently a couple of issues with that repository which means it won't work with 3.13 yet.

lucas42 · 2024-10-14T22:44:48Z

I've submitted a pull request to the python-deadlib library to try to get its aifc fork from the python core working on python 3.13: youknowone/python-deadlib#9

Another potential approach would be to handle the ModuleNotFoundError more gracefully here. That would reduce the range of file types supported on python3.13, but is still better than a hard error, even when aifc support isn't needed!

…repo to prevent import errors on Python 3.13 Workaround for beetbox/audioread#144

lucas42 · 2024-10-30T18:33:25Z

The python-deadlib modules have now been fixed up and can be used to replace the missing modules from python core.

So a workaround to this issue is pip install standard-aifc standard-sunau

…and above. Python core removed these modules in 3.13 as part of PEP-594 https://peps.python.org/pep-0594/ The standard-* modules are forks of the modules that had previously been in the python core. Fixes beetbox#144

montvid · 2024-12-07T11:19:09Z

The library does not build on python 3.12 too Anjok07/ultimatevocalremovergui#1578 (comment)

pipx >(analyze_pip_output:311): pip seemed to fail to build package:
    audioread==3.0.0

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    ModuleNotFoundError: No module named 'imp'

lucas42 · 2024-12-08T13:12:39Z

@montvid I don't think your error is related to this issue.

Looks like that the imp issue might have been fixed in 3.0.1 (see #136 )
I'd guess ultimatevocalremovergui just needs to update its dependencies to the latest release.

lucas42 mentioned this issue Oct 14, 2024

Bump python from 3.12 to 3.13 lucas42/lucos_media_import#49

Merged

lucas42 added a commit to lucas42/lucos_media_import that referenced this issue Oct 25, 2024

Manually install aifc and sunau libraries from python-deadlib github …

88062b9

…repo to prevent import errors on Python 3.13 Workaround for beetbox/audioread#144

lucas42 linked a pull request Oct 30, 2024 that will close this issue

Add support for Python 3.13 #145

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`aifc` module is deprecated (and removed in Python 3.13) #144

`aifc` module is deprecated (and removed in Python 3.13) #144

mgorny commented Jun 13, 2024

lucas42 commented Oct 14, 2024

lucas42 commented Oct 14, 2024

lucas42 commented Oct 30, 2024

montvid commented Dec 7, 2024

lucas42 commented Dec 8, 2024

aifc module is deprecated (and removed in Python 3.13) #144

aifc module is deprecated (and removed in Python 3.13) #144

Comments

mgorny commented Jun 13, 2024

lucas42 commented Oct 14, 2024

lucas42 commented Oct 14, 2024

lucas42 commented Oct 30, 2024

montvid commented Dec 7, 2024

lucas42 commented Dec 8, 2024

`aifc` module is deprecated (and removed in Python 3.13) #144

`aifc` module is deprecated (and removed in Python 3.13) #144