Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check python version and enable https where it's possible #2307

Merged
merged 22 commits into from
Jan 3, 2017
Merged

Check python version and enable https where it's possible #2307

merged 22 commits into from
Jan 3, 2017

Commits on Dec 5, 2016

  1. Check python version and enable https where it's possible

    @tigranl
    tigranl committed Dec 5, 2016
    Configuration menu
    Copy the full SHA
    43fcb3d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2016

  1. Python version check for lyrics.py

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    6ba5099 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:beetbox/beets into https_fix

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    0fb19cf View commit details
    Browse the repository at this point in the history

  3. Add SNI_SUPPORTED variable for https check

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    f60c911 View commit details
    Browse the repository at this point in the history

  4. Add SNI_SUPPORTED variable for https check

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    73a7a4f View commit details
    Browse the repository at this point in the history

  5. Add SNI_SUPPORTED variable for https check

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    d065b33 View commit details
    Browse the repository at this point in the history

  6. Add SNI_SUPPORTED variable for https check

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    5ae1376 View commit details
    Browse the repository at this point in the history

  7. Revert "Add SNI_SUPPORTED variable for https check" 

    This reverts commit f60c911.
    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    25ebf89 View commit details
    Browse the repository at this point in the history

  8. Add SNI_SUPPORTED

    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    91819b2 View commit details
    Browse the repository at this point in the history

  9. Add SNI_SUPPORTED 

    Add SNI_SUPPORTED
    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    efa9041 View commit details
    Browse the repository at this point in the history

  10. Add SNI_SUPPORTED 

    Add SNI_SUPPORTED

Add SNI_SUPPORTED
    @tigranl
    tigranl committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    420c451 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2016

  1. Add tests for https

    @tigranl
    tigranl committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    9bba178 View commit details
    Browse the repository at this point in the history

  2. Add SNI_SUPPORTED

    @tigranl
    tigranl committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    21208b8 View commit details
    Browse the repository at this point in the history

  3. Add SNI_SUPPORTED

    @tigranl
    tigranl committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    b65a7da View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2016

  1. Add tests for https

    @tigranl
    tigranl committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    68b4a03 View commit details
    Browse the repository at this point in the history

  2. PEP8 corrections

    @tigranl
    tigranl committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    0868299 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @tigranl
    tigranl committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    471f875 View commit details
    Browse the repository at this point in the history

  4. Fix typos

    @tigranl
    tigranl committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    5ca664e View commit details
    Browse the repository at this point in the history

  5. Add ui import

    @tigranl
    tigranl committed Dec 10, 2016
    Configuration menu
    Copy the full SHA
    dd115b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2016

  1. Fix a typo

    @tigranl
    tigranl authored Dec 31, 2016
    Configuration menu
    Copy the full SHA
    1c5c74f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2017

  1. Always use SSL on servers that don't require SNI 

    I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:

icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI

In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
    @sampsyo
    sampsyo committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    f941fd4 View commit details
    Browse the repository at this point in the history

  2. Simplify test changes 

    We don't need quite so many checks now that SSL isn't conditional most of the
time.
    @sampsyo
    sampsyo committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    33a8e81 View commit details
    Browse the repository at this point in the history