This repository has been archived by the owner on Aug 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
XHProf role requires an internet connection during provision #45
Labels
Comments
My preference would be to remove xhprof from the defaults until the PR is merged upstream. |
Agreed. However, currently the PR I made for XHProf needs work as it is failing tests; It appears there's a false negative where if no version is detected (eg, it needs to be installed) the test is failing rather than installing XHProf. |
Decipher
added a commit
to Decipher/beetbox
that referenced
this issue
Jan 20, 2016
Merged a temporary removal of XHProf from the base box (won't come into play until the next build). Have also updated the PR (geerlingguy/ansible-role-php-xhprof#2) so that it should now pass the tests. |
I believe this should be fixed upstream as soon as Centos 6 starts behaving and this PR gets merged: geerlingguy/ansible-role-php-xhprof#12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The XHProf role currently requires an internet connection during provision as it tries to install both the PECL channel and package regardless of whether it is already installed (which it is in Beetbox).
As such, it means that anyone trying to provision offline with the defaults (having XHProf role being installed) will not be able to do so.
I have already submitted a PR to the role that will resolve the issue (geerlingguy/ansible-role-php-xhprof#2), but until that PR is accepted we should consider a short-term fix.
The options I can see are:
The text was updated successfully, but these errors were encountered: