-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
@@ -7,8 +7,8 @@ Vagrant.require_version '>= 1.8.0' | |||
|
|||
cwd = File.dirname(File.expand_path(__FILE__)) | |||
config_dir = '.beetbox/' | |||
vagrant_config = "#{cwd}/#{config_dir}config.yml" | |||
local_config = "#{cwd}/#{config_dir}local.config.yml" | |||
project_config = "#{dir}/#{config_dir}config.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression error, changing back to dir
which is not set will cause this Vagrantfile to break.
Updated to use |
Code looks good, will have to run a few manual tests to confirm for sure though. |
Missed a change on line 23; Still references |
Should also make these changes to the box Vagrantfile. |
56bf93d
to
254ced3
Compare
31c371b
to
04a9b8e
Compare
Updated box Vagrantfile - having both of these in the project will make it really difficult/confusing for any new contributors, we should look at tidying it up ASAP -- #94 The Vagrantfile's should be exactly the same except for the skip conditions for the box version. |
This PR doesn't 100% resolve the issue, due to the definition of 'empty'. If I have a
However, if the I assume the completely empty file is not a valid YAML file, but it seems more likely to be the case than a valid empty YAML config file. |
Currently if a config files exists but has no YAML vars defined vagrant will error.