Redeploy with right vault address. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmkm
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Fix backwards rate in UnbuttonLinearPool (#3) * wrapped aave ampl - wrapped ampl linear pool * Remove redundant wrapped token storage, no longer necessary * Use FixedPoint.ONE * Fix tests broken by interface change * Fix backwards rate Balancer defines linear pool rates as main per wrapped, whereas Ampleforth's understanding comes from the UnbuttonToken wrapper which defines the initialization rate as wrapped per underlying. * unbutton wrapper relayer (#4) * Add unbutton linear pool factory * Add test for unbutton factory, extract helper from pool test * Remove redundant mock unbutton token * Fix minor comment typos * Reframe code as main/wrapped, comments as wAMPL/wAaveAMPL * Alphabetize imports and lint * Lint * Remove redundant IButtonWrapper * Fix broken test * MockUnbuttonERC20: implement IButtonWrapper * Add license block * Fix import style * Remove mock rebasing token dependency from tests * Add IUnbuttonToken interface to clean up some code * Propagate IUnbuttonToken to factory as well Co-authored-by: rabmarut <rabmarut@protonmail.com> Co-authored-by: nithin <nithin@fragments.org> Co-authored-by: Brandon Iles <brandon.iles@gmail.com>
danielmkm
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Protocol fee splitter wip * add more tests * add deployment, minor changes * Minor changes regarding errors in tests * Add default default revenue sharing fee percentage * update function to pure * Add Pool's beneficiary * Use ProtocolFeesWithdrawer instead of ProtocolFeesCollector (#2) * Protocol fee splitter refactor (#3) * remove unused errors * Update deployment script for ProtocolFeeSplitter * update test, style change * Update MockPool * update modifier on MockPool * Remove getOwner from IBasePool * Fix linter error * Remove getOwner from MockPool * Last protocol fee splitter fixes (#4) * Fix task inputs * Update readmes and changelogs * Hide struct inside contract * Make interfaces 'view' * Fix iface docs * Minor refactors * Rename random to other * Minor test simplifications * Split getter tests * Remove unused values * Fix test transfer * Fix test * Update pkg/interfaces/contracts/standalone-utils/IProtocolFeeSplitter.sol Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.