fix Dockerfile and entrypoint script #20
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In entrypoint script
launch.sh
By using
exec "$@"
at the end,nginx
will bePID 1
inside the docker container, instead of/bin/sh
. It also allows kill signals to reachnginx
directly from the docker host.In Dockerfile
By using
ENTRYPOINT ["./launch.sh"]
it makes it clear thatlaunch.sh
is the entrypoint, especially when usingdocker inspect <image>
.By using
CMD ["nginx", "-g", "daemon off;"]
, it allows the users to override the CMD if they prefer.