Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile and entrypoint script #20

Closed
wants to merge 1 commit into from

Conversation

leojonathanoh
Copy link

In entrypoint script launch.sh

By using exec "$@" at the end, nginx will be PID 1 inside the docker container, instead of /bin/sh. It also allows kill signals to reach nginx directly from the docker host.

In Dockerfile

By using ENTRYPOINT ["./launch.sh"] it makes it clear that launch.sh is the entrypoint, especially when using docker inspect <image>.
By using CMD ["nginx", "-g", "daemon off;"], it allows the users to override the CMD if they prefer.

Base automatically changed from master to latest February 13, 2021 22:15
@beevelop
Copy link
Owner

Fixed through #30

@beevelop beevelop closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants