-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FORCE_COLOR
to enable colored output in CI
#36
Conversation
hmm....this is activating the Rich progress bar....creating some definitely undesired CI logs (see Build iOS App). Looking over the Rich docs, it says:
However, immediately preceding that in the Interactive Mode section:
So, given that Rich is basically explicitly referencing this situation....and says "change the way youre initializing Because this doesn't only affect BeeWare's own CI; this would affect anyone trying to use Briefcase in their own CI with |
In Briefcase, we'd have to really move some things around to control how However, it is simple to disable the use of Rich animations based on an arbitrary flag. I pushed a commit to disable progress bars and wait bars if the @freakboy3742, can you please provide your thoughts on these changes?
|
If there's an emerging environment based standard, it makes sense to me to adopt it. It's a lot easier to set this flag once, and then have every tool pick it up, rather than have to remember to turn on colors for each individual tool invocation. However - can I get a confirmation on whether the the flag is
Definitely agree that there's a need to be able to disable the animations; I guess my question is whether we should overload If we can't - the only practical use of |
FORCE_COLORS
to enable colored output in CIFORCE_COLOR
to enable colored output in CI
It's
So, Rich is simply short-circuiting its "is tty" logic when I'm somewhat hesitant to introduce our own detection since it's only really relevant to Rich. However, a call to Personally, I'd rather let Rich do what it does but allow users to turn it off in non-interactive sessions.
It's also very useful for quickly creating the helloworld app :) |
Agreed. This isn't an area where need reinvent wheels. Piggybacking on
True - but in that case, you probably also want the progress bars so you can see the downloads happening. |
I went round and round for a bit trying different things...but landed on beeware/briefcase#1267. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
FORCE_COLOR=1
to activate color output in CINotes
FORCE_COLOR
FORCE_COLOR
for the most part:pytest
had been usingPY_COLOR
env var for a while...but it never really caught onFORCE_COLOR
made sensetox
has supported it since v4pytest
has supported it since v6pip
is supposed to respectFORCE_COLOR
, I don't see it working in CI...PR Checklist: