Add reusable actions to create and/or verify a new project #68
Conversation
rmartin16
force-pushed
the
create-new-project
branch
18 times, most recently
from
2f6a58c to
d77e116
Compare
|
This really creates some chicken and egg problems.... |
rmartin16
force-pushed
the
create-new-project
branch
4 times, most recently
from
a92dfc6 to
ea78040
Compare
|
So, I'm trying to get to a place where none of the downstream repos need to have project creation config or pre-rolled out apps for CI. I've removed the need for the config...but the rolled apps will be more difficult since they include specific This really seems quite ripe for a plugin that adds |
I was literally about to break ground on this feature today. tl;dr |
rmartin16
force-pushed
the
create-new-project
branch
5 times, most recently
from
577840c to
fd87e02
Compare
rmartin16
force-pushed
the
create-new-project
branch
from
eb289f2 to
eda4d6a
Compare
- Use `actions/setup-python` to manage caching for `pip` - Stop trying to cache Docker images since it would be unreasonable anyway given the size of images being used - Stop caching cookiecutter templates since downloading as part of a cache or downloading via `git` from GitHub are effectively the same - Continue caching the Briefcase data directory
rmartin16
force-pushed
the
create-new-project
branch
10 times, most recently
from
d2f6816 to
ee00f93
Compare
rmartin16
force-pushed
the
create-new-project
branch
from
ee00f93 to
90f94b8
Compare
…thon - At least one of the file from `cache-dependency-path` must exist
rmartin16
force-pushed
the
create-new-project
branch
from
4a638c6 to
2cefb4c
Compare
…ses` - Both `app-build-verify` and `app-create-verify` will detect when the current repo is `briefcase-template` and will use the `github.workspace` as the project template - All of cases will use the default propject template
.github/workflows/ci.yml
Outdated
|
|
||
| test-docs-build-verify: | ||
| name: Test Verify Docs Build | ||
| name: Verify Docs Build Check |
There was a problem hiding this comment.
Minor Nit: The task is verifying the docs build; verifying a check is... a bit meta.
| name: Verify Docs Build Check | |
| name: Verify Docs Build |
| - name: Checkout beeware/briefcase-template | ||
| uses: actions/checkout@v4.1.1 | ||
| with: | ||
| repository: rmartin16/briefcase-template # !!!!! TODO:PR: REPLACE ME WITH beeware/briefcase-template !!!!! | ||
| ref: gui-plugin-support # !!!!! TODO:PR REMOVE ME !!!!! | ||
| path: briefcase-template |
There was a problem hiding this comment.
It isn't clear why I added this....but it definitely isn't necessary now. It should be removed when the updates are made prior to merging.
There was a problem hiding this comment.
Ohh nvm, i see now. This is needed to install the requirements for linting the project. So, it should stick around.
| run: | | ||
| cd tests/apps/verify-${{ inputs.framework }} | ||
| briefcase create linux system --target fedora:37 | ||
| briefcase create linux system --target fedora:37 \ |
There was a problem hiding this comment.
Doesn't need to be fixed in this PR, but flagging that Fedora 37 is EOL in 2 weeks, so we're likely going to need to bump this to 38 or 39 soon.
There was a problem hiding this comment.
👍🏼 I should take care of this in my next round of PRs. I think some of the versions in the templates (e.g. for org.kde.Platform) need bumps as well.
There was a problem hiding this comment.
Marking as approved, conditional on changes that are needed as part of the beeware/briefcase#1524 landing strategy
Changes
app-create-verify.yml, for repos to run in CI that have impacts on project creationbeeware/briefcase-templateandbeeware/briefcaseshould implement thisBRIEFCASE_REPO: https://github.com/rmartin16/briefcase
BRIEFCASE_REF: gui-plugin-support
BRIEFCASE_TEMPLATE_REPO: https://github.com/rmartin16/briefcase-template
BRIEFCASE_TEMPLATE_REF: gui-plugin-support
PR Checklist: