Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrap xcrun --sdk arguments in quotes to allow spaces #241

Closed
wants to merge 1 commit into from

Conversation

FeodorFitsner
Copy link

Calling arm64-apple-ios-clang script (and other aliases as well) fails if arguments contain spaces, for example:

arm64-apple-ios-clang -DPACKAGE_TARNAME="aaa" -DPACKAGE_STRING="aaa 1.2.2" -c -o src/main.o src/main.c

gives clang: invalid directory name: '1.2.2"' error.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I can see how this is a problem, and how the patch you've provided will fix the problem - but this is an example of something that should be submitted upstream to CPython. The shims come from CPython itself, and the patch set in this repo is generated automatically from the freakboy3742/cpython fork of that repository (applying additional patches). If this patch were applied to the support repo, it would be deleted the next time we did an update.

So - I suggest submitting this set of changes as an issue report followed by a PR on CPython itself; I'm a committer there as well, so I can merge and backport it to 3.13, and then backport to the 3.9-3.12 branches as well.

I'm going to close this PR on that basis - but I encourage you to log the issue with CPython, and then submit this set of changes as a PR.

@FeodorFitsner
Copy link
Author

Sounds good, will do a PR to CPython repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants