Skip to content

PROPOSAL: Use 400 weight for H1 and H2, fall back to sans-serif for Simplified and Traditional Chinese headings #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
johnzhou721 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

PROPOSAL: Use 400 weight for H1 and H2, fall back to sans-serif for Simplified and Traditional Chinese headings #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/beeware_docs_tools/overrides/assets/stylesheets/beeware_theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,21 @@
src: url("../fonts/Cutive.woff2");
}

:root {
--brand-font: "Cutive", serif;
}

:lang(zh),
:lang(zh_CN),
:lang(zh_TW) {
--brand-font: "Cutive", sans-serif;
}

/*----------------------------------------------------
Build BeeWare header
--------------------------------------------------- */
.navbar {
font-family: 'Cutive', serif;
font-family: var(--brand-font);
position: relative;
display: -ms-flexbox;
display: flex;
Expand Down Expand Up @@ -294,10 +304,18 @@
.md-typeset h4,
.md-typeset h5,
.md-typeset h6 {
font-family: 'Cutive', serif;
font-family: var(--brand-font);
color: var(--md-typeset-color);
}

/* Bump the font weight slightly for h1 and h2. This will make fonts in some scripts,
e.g. Chinese have more consistent weights with Cutive, which is thicker than most
typical 300-weight fonts. Cutive itself does not get emboldened by using 400. */
.md-typeset h1,
.md-typeset h2 {
font-weight: 400;
}

/* Fix issue with spacing when title is exactly the width of the article column */
.md-typeset h1 a.headerlink {
display: none;
Expand Down Expand Up @@ -338,7 +356,7 @@ a.md-nav__link[for]:hover {

/* Sidebar title and GitHub links font and color */
.md-nav__title {
font-family: 'Cutive', serif;
font-family: var(--brand-font);
}

.md-nav__title {
Expand Down Expand Up @@ -426,7 +444,7 @@ a.md-nav__link[for]:hover {

/* The menu button for the sidebar drawer to display the sidebar on smaller displays */
.mobile-drawer-button-site-name {
font-family: Cutive, "serif";
font-family: var(--brand-font);
font-size: 16px;
display: inline-block;
vertical-align: middle;
Expand Down Expand Up @@ -652,7 +670,7 @@ svg.copy-icon {

/* Search */
input.md-search__input, .md-search__suggest, .md-search-result__meta {
font-family: 'Cutive', serif;
font-family: var(--brand-font);
}

.md-search__suggest {
Expand Down