Add permissions callback hook. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mhsmith
reviewed
Jan 29, 2024
{{ cookiecutter.format }}/app/src/main/java/org/beeware/android/IPythonApp.java
Outdated
Show resolved
Hide resolved
4 tasks
Co-authored-by: Malcolm Smith <smith@chaquo.com>
mhsmith
approved these changes
Jan 29, 2024
mhsmith
reviewed
Jan 29, 2024
| @@ -13,4 +13,6 @@ public interface IPythonApp { | |||
| void onConfigurationChanged(Configuration newConfig); | |||
| boolean onOptionsItemSelected(MenuItem menuitem); | |||
| boolean onPrepareOptionsMenu(Menu menu); | |||
| // There's no need to add any more methods to this interface, as the Python | |||
There was a problem hiding this comment.
Oops, pre-commit whitespace failure.
Suggested change
| // There's no need to add any more methods to this interface, as the Python | |
| // There's no need to add any more methods to this interface, as the Python |
|
Queuing for re-review, as I've added the file provider declaration to this PR. |
|
I've merged this with the changes from #82 that landed. As a result, this PR should be mergable without any risk to main usage of briefcase; and when it has been merged, beeware/toga#2353 should pass. |
mhsmith
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve permissions requests, we need a callback hook on the Java side of an Android app.
Also bumps the appcompat version to ensure availability of the CurrentContext helper, needed to evaluate permissions.
PR Checklist: