Adding option for creating template of Positron (Django or Static) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
freakboy3742
requested changes
May 22, 2023
There was a problem hiding this comment.
One comment inline about the specifics of this template; however, I think there's a bigger design issue to tackle. See beeware/briefcase#392 for details.
| # See https://docs.djangoproject.com/en/4.2/howto/deployment/checklist/ | ||
|
|
||
| # SECURITY WARNING: keep the secret key used in production secret! | ||
| SECRET_KEY = 'django-insecure-86kqbg4s&53!bmq5)pd0hg@a%7b1pn_7&yw(tljy=xh12*!_u$' # noqa: E501 |
There was a problem hiding this comment.
This should probably be generated by the template, rather than hard-coded with a warning.
There was a problem hiding this comment.
we can also strip back the code to not include those generate by Django, anyway, will close this PR
|
I am using this for the quick demo for now, will open a new PR when there is a solution for the GUI framework plug-in described in beeware/briefcase#1288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to create a project using Django or Static Position (supported by Toga). I will be using it for my tutorial but I don't know if it is useful to push back upstream - feel free to have a look and discuss.
PR Checklist:
Happy to add tests and docs if it is desired upstream, let's talk about it.