Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codesign --deep is deprecated and should be removed #1221

Closed
glyph opened this issue Apr 24, 2023 · 1 comment · Fixed by #1835
Closed

codesign --deep is deprecated and should be removed #1221

glyph opened this issue Apr 24, 2023 · 1 comment · Fixed by #1835
Labels
bug A crash or error in behavior. macOS The issue relates to Apple macOS support.

Comments

@glyph
Copy link

glyph commented Apr 24, 2023

Describe the bug

From man codesign:

     --deep  (DEPRECATED for signing as of macOS 13.0) When signing a bundle, specifies that nested code content such as helpers,
             frameworks, and plug-ins, should be recursively signed in turn.
             Beware:

followed by a whole bunch of caveats. Any embedded bundles still need to be signed after signing all of their contents individually, but --deep just isn't that useful of an option; it's quite limited and anywhere that briefcase isn't finding the right stuff to sign that's a bug on its own and should be fixed.

Steps to reproduce

N/A

Expected behavior

don't use --deep

Screenshots

No response

Environment

N/A

Logs

No response

Additional context

No response

@glyph glyph added the bug A crash or error in behavior. label Apr 24, 2023
@freakboy3742 freakboy3742 added the macOS The issue relates to Apple macOS support. label Mar 7, 2024
phildini added a commit that referenced this issue May 22, 2024
Fixes `codesign --deep` is deprecated and should be removed #1221
@glyph
Copy link
Author

glyph commented May 22, 2024

Woohoo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior. macOS The issue relates to Apple macOS support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants