Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for updates to pre-commit hooks every Sunday #1070

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 29, 2023

Waiting on flake8-eradicate to be updated for flake8>=6
- wemake-services/flake8-eradicate#271

Updated pre-commit hooks and dropped support for flake8-eradicate due to extended incompatibility with flake8==6.0.0.

See beeware/.github#6 for details.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review January 29, 2023 22:29
@rmartin16 rmartin16 force-pushed the pre-commit-autoupdate branch 2 times, most recently from b53049a to c4eb017 Compare January 29, 2023 22:33
@rmartin16 rmartin16 marked this pull request as draft January 29, 2023 22:58
@freakboy3742
Copy link
Member

@rmartin16 Is this ready to come out of draft? It looks like it should be up to date and ready to merge, but I wanted to check you haven't got something else in mind.

@rmartin16
Copy link
Member Author

rmartin16 commented Feb 2, 2023

It could come out of draft....but the PR the workflow will create won't be mergeable because flake8-eradicate doesn't have a release compatible with flake8==6.0.0. That's the case as well with a few other of these PRs.

@freakboy3742
Copy link
Member

@rmartin16 So... there's been an open PR to fix this problem since Dec 4; that doesn't seem to suggest they're particularly responsive as a project. While flake8-eradicate is a nice-to-have tool, I wouldn't call it essential. Would it be worth considering dropping it entirely (or, at least, dropping it for now, until such time as they release a version that is compatible)?

@mhsmith
Copy link
Member

mhsmith commented Feb 2, 2023

Does this workflow create separate PRs per requirement, like dependabot? If so, we can simply delay merging the flake8 bump until it's safe to do so.

@rmartin16
Copy link
Member Author

@mhsmith: No, this workflow does not (presently) create separate PRs for each pre-commit hook. The basic mechanics are available to do this, though, since pre-commit supports updating a single hook via pre-commit autoupdate --repo <REPO>. From there, the repos for all the hooks would need to be enumerated and so forth....(I am mostly hoping that Dependabot adds support for pre-commit before doing all this :) )

I'm fine with dropping flake8-eradicate for now, though; commits inbound.

@rmartin16 rmartin16 marked this pull request as ready for review February 2, 2023 18:30
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit bc68cf4 into beeware:main Feb 2, 2023
@rmartin16 rmartin16 deleted the pre-commit-autoupdate branch February 2, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants