-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop unintentionally creating a folder during tests on Windows #1188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; one suggested cleanup/reversion around the autouse
on the now
fixture.
tests/console/test_Log.py
Outdated
from briefcase.exceptions import BriefcaseError | ||
|
||
TRACEBACK_HEADER = "Traceback (most recent call last)" | ||
EXTRA_HEADER = "Extra information:" | ||
|
||
|
||
@pytest.fixture | ||
@pytest.fixture(autouse=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of autouse
- outside of "whole of test suite" configuration setup, I find explicit is better than implicit. For the sake of including a now
fixture in a handful of tests, which makes it clear that "this test has a specific time interpretation".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair; also removed it from Windows SDK tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Changes
mkdir()
to fail.Reference
PR Checklist: