Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tox to 4.6.0 and remove workarounds to avoid pip 23.1 #1301

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Bump tox to 4.6.0 and remove workarounds to avoid pip 23.1 #1301

merged 1 commit into from
Jun 5, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jun 5, 2023 •
edited
Loading

Changes

  • Tox bumped its minimum requirement for virtualenv to 20.23
  • Since virtualenv 20.23 embeds pip 23.1.2, the workarounds to avoid pip 23.1 are moot
  • This restores a small speed improvement to tox environments since they will no longer always download the latest pip and setuptools

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review June 5, 2023 15:36
@freakboy3742 freakboy3742 merged commit 96479a0 into beeware:main Jun 5, 2023
@rmartin16 rmartin16 deleted the update-tox branch June 11, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742