Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CI to succeed on Python 3.12 #1476

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Oct 3, 2023

Changes

  • CI uses latest stable 3.12 release and tests are required to succeed now

Notes

  • Python 3.12 is not available in Windows Store yet
  • Running tests against Python 3.13 is not an option yet....and I'm not really sure when to expect it to be available...
  • I'm not sure if there are bigger plans to incorporate m1 macOS testing yet...but feel free to supersede this PR

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16
Copy link
Member Author

will probably just wait on the win store and 3.13-dev unless a compelling reason to merge sooner presents

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're obviously waiting for the 3.12 images to become available, but as soon as those are ready, this looks good.

I'm not sure what Steve Dower's plans are regarding the windows store version of 3.12; I'm happy to deal with that as a separate PR if it doesn't land before the 3.12 runner becomes available.e

I'm still trying to work out what we can do with M1 runners; there doesn't appear to be a free tier, so I need to work out what the cost will be if I turn those on. For now, I'm happy to live without M1 runners on Briefcase.

3.13.0a1 should land October 17, so it seems reasonable to assume the Python installation action will be updated a couple of days after that.

@rmartin16
Copy link
Member Author

We're obviously waiting for the 3.12 images to become available, but as soon as those are ready, this looks good.

They landed this morning. These CI checks ran against Python 3.12.0.

I'm still trying to work out what we can do with M1 runners; there doesn't appear to be a free tier, so I need to work out what the cost will be if I turn those on. For now, I'm happy to live without M1 runners on Briefcase.

3.13.0a1 should land October 17, so it seems reasonable to assume the Python installation action will be updated a couple of days after that.

👍🏼

@rmartin16 rmartin16 marked this pull request as ready for review October 3, 2023 22:47
@freakboy3742 freakboy3742 merged commit 8e3d391 into beeware:main Oct 3, 2023
36 checks passed
@rmartin16 rmartin16 deleted the ci-python3.12 branch October 3, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants