Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Android SDK Commandline Tools from 9.0 to 12.0 #1778

Merged
merged 1 commit into from
May 9, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented May 6, 2024

Changes

  • Requires Android Commandline Tools 12.0
  • Whether using Briefcase's SDK install or a user-managed one, version 12.0 will just be installed if it isn't already

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the cmdline-tools-12.0 branch 8 times, most recently from 39c1f06 to 1d03718 Compare May 7, 2024 23:04
@rmartin16
Copy link
Member Author

well....ever keeping us on our toes....Google's AVD manager in cmdline-tools v12.0 apparently respects XDG_CONFIG_HOME. So, the AVD config is in ~/.config/.android/avd instead of ~/.android/avd now....and Briefcase can't find the AVD's config to update it...

@rmartin16
Copy link
Member Author

FWIW, Android Studio will also respect XDG_CONFIG_HOME when creating an AVD.

However, $BRIEFCASE_HOME/tools/android_sdk/emulator/emulator will not be able to find this AVD that was just created in $XDG_CONFIG_HOME/.android.....because (surprise surprise) it doesn't respect XDG_CONFIG_HOME.

The avdmanager does support a -p/--path to define "the location where the directory for this AVD's files will be created".....but it still puts the AVD's ini file in $XDG_CONFIG_HOME/.android (!!!!!!) and we still have the same issue.

So, anyway....I think it'll be best to ensure XDG_CONFIG_HOME is always overridden when running avdmanager...

@rmartin16 rmartin16 force-pushed the cmdline-tools-12.0 branch 4 times, most recently from 8b65df3 to 9390ba7 Compare May 8, 2024 16:21
@rmartin16 rmartin16 marked this pull request as ready for review May 8, 2024 16:47
@rmartin16
Copy link
Member Author

hmm...another PytestUnraisableExceptionWarning...although transient: https://github.com/beeware/briefcase/actions/runs/9005657139/job/24741533654?pr=1778

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freakboy3742 freakboy3742 merged commit d1c5e72 into beeware:main May 9, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants