Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all files are unique for check-wheel-contents #1839

Merged
merged 1 commit into from
May 26, 2024

Conversation

rmartin16
Copy link
Member

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm intrigued to know what this check is actually be protecting against... but no objection to complying.

@rmartin16
Copy link
Member Author

fwiw, their documentation says (1) "you copied a file when you meant to rename it" or (2) "you built a wheel, renamed a file, and re-created the wheel without deleting the build directory first".

Number (2) sounds like a historical problem....but number (1) seems reasonable I guess. I'd argue, though, it is late in the process to be catching this when you're building a wheel but...

@freakboy3742 freakboy3742 merged commit af84adb into beeware:main May 26, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants