Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supplant appdirs with platformdirs #783

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Supplant appdirs with platformdirs #783

merged 1 commit into from
Jul 13, 2022

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jul 13, 2022 •
edited
Loading

Based on @dgelessus astute comment that appdirs has been effectively superseded by platformdirs in the python ecosystem, this PR updates the OS-native data directory implementation in #777 from using appdirs to platformdirs.

platformdirs explicitly advertises itself as a drop-in replacement for appdirs by even aliasing platformdirs.PlatformDirs to platformdirs.AppDirs.

Additionally, platformdirs goes the extra step and provides APIs that return pathlib.Path objects directly.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #783 (f8a6ec4) into main (baf2942) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/briefcase/commands/base.py 98.32% <100.00%> (ø)

@rmartin16 rmartin16 marked this pull request as ready for review July 13, 2022 14:38
freakboy3742
freakboy3742 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I do like a good API-compatible drop in :-)

@freakboy3742 freakboy3742 merged commit a17e62f into beeware:main Jul 13, 2022
@rmartin16 rmartin16 mentioned this pull request Jul 14, 2022
Closed
4 tasks
@rmartin16 rmartin16 deleted the platformdirs branch January 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742