Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document process of customizing AppImage DockerFile. #954

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

freakboy3742
Copy link
Member

beeware/briefcase-linux-appimage-template#22 added the option of Dockerfile customisation to the template. No changes to Briefcase are needed to support this; however, this new option needs to be documented.

Refs beeware/briefcase-linux-appimage-template#22
Refs #886

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith merged commit 330b0d9 into beeware:main Nov 7, 2022
@freakboy3742 freakboy3742 deleted the dockerfile_extra_content branch November 7, 2022 23:39
@freakboy3742
Copy link
Member Author

This merge was premature given that beeware/briefcase-linux-appimage-template#22 hasn't been merged yet; we may need additional documentation changes, depending on the outcome of that discussion.

@mhsmith
Copy link
Member

mhsmith commented Nov 8, 2022

Yes, sorry, I realized that too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants