Future-proof Chart against changing Toga Widget initialization #194
Conversation
There was a problem hiding this comment.
Agreed this makes sense in the light of beeware/toga#2942 changes; one possible way to avoid the backwards incompatibility at all, plus any additional changes that are needed as a result of the final review state of beeware/toga#2942.
src/toga_chart/chart.py
Outdated
| if not self._impl: | ||
| # Backwards compatibility for Toga 0.4.8, which does not call the _create() | ||
| # method in Widget.__init__() | ||
| self._create() |
There was a problem hiding this comment.
We can also fix this by a toga dependency to toga-core>=0.4.8. It's an interesting omission that we don't currently have that dependency, only enforcing the toga-dummy requirement on developers.
There was a problem hiding this comment.
Oh. Yeah. That is a good point! I'll just change it to that once we know for sure what the next version number is.
There was a problem hiding this comment.
I've removed the backwards compatibility shim and added the version requirement (which fails for now, of course, since Toga 0.5.0 doesn't exist).
Updates Chart to play nice with the restructured Widget initialization in beeware/toga#2942, while staying backwards compatibile with Toga 0.4.8.
I realize that PR may or may not change significantly before merging; this is for its current form as of beeware/toga@c4db37f, and I can amend as needed.
PR Checklist: