Merge pull request #2482 from freakboy3742/memory-retention

Remove some over-enthusiastic memory retention.
beeware · Apr 16, 2024 · 4398e2a · 4398e2a
2 parents 3ccab57 + d9e6565
commit 4398e2a
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 4 deletions.
diff --git a/changes/2472.bugfix.rst b/changes/2472.bugfix.rst
@@ -1 +1 @@
-Fix memory leaks for toga.Icon and toga.Image in the Cocoa backend.
+Some memory leaks associated with macOS Icon and Image storage were resolved.
diff --git a/changes/2482.bugfix.rst b/changes/2482.bugfix.rst
@@ -0,0 +1 @@
+Some memory leaks associated with the macOS Table, Tree and DetailedList widgets were resolved.
diff --git a/cocoa/src/toga_cocoa/widgets/detailedlist.py b/cocoa/src/toga_cocoa/widgets/detailedlist.py
@@ -83,7 +83,6 @@ def tableView_objectValueForTableColumn_row_(self, table, column, row: int):
             data = value._impl
         except AttributeError:
             data = TogaData.alloc().init()
-            data.retain()
             value._impl = data
 
         try:

diff --git a/cocoa/src/toga_cocoa/widgets/table.py b/cocoa/src/toga_cocoa/widgets/table.py
@@ -73,7 +73,6 @@ def tableView_viewForTableColumn_row_(self, table, column, row: int):
 
             # Prevent tcv from being deallocated prematurely when no Python references
             # are left
-            tcv.retain()
             tcv.autorelease()
 
         tcv.setText(str(value))

diff --git a/cocoa/src/toga_cocoa/widgets/tree.py b/cocoa/src/toga_cocoa/widgets/tree.py
@@ -101,7 +101,6 @@ def outlineView_viewForTableColumn_item_(self, tree, column, item):
 
             # Prevent tcv from being deallocated prematurely when no Python references
             # are left
-            tcv.retain()
             tcv.autorelease()
 
         tcv.setText(str(value))