Remove need for Document to have an implementation.

beeware · Jul 1, 2024 · ccbc45b · ccbc45b
1 parent ea2e6e5
commit ccbc45b
Show file tree

Hide file tree

Showing 10 changed files with 4 additions and 103 deletions.
diff --git a/cocoa/src/toga_cocoa/documents.py b/cocoa/src/toga_cocoa/documents.py
diff --git a/cocoa/src/toga_cocoa/factory.py b/cocoa/src/toga_cocoa/factory.py
@@ -3,7 +3,6 @@
 from . import dialogs
 from .app import App
 from .command import Command
-from .documents import Document
 from .fonts import Font
 from .hardware.camera import Camera
 from .hardware.location import Location
@@ -46,7 +45,6 @@ def not_implemented(feature):
     "not_implemented",
     "App",
     "Command",
-    "Document",
     # Resources
     "Font",
     "Icon",

diff --git a/cocoa/src/toga_cocoa/libs/appkit.py b/cocoa/src/toga_cocoa/libs/appkit.py
@@ -273,15 +273,6 @@ class NSBezelStyle(IntEnum):
 
 NSCursor = ObjCClass("NSCursor")
 
-######################################################################
-# NSDocument.h
-NSDocument = ObjCClass("NSDocument")
-
-######################################################################
-# NSDocumentController.h
-NSDocumentController = ObjCClass("NSDocumentController")
-NSDocumentController.declare_class_property("sharedDocumentController")
-
 ######################################################################
 # NSEvent.h
 NSEvent = ObjCClass("NSEvent")

diff --git a/core/src/toga/documents.py b/core/src/toga/documents.py
@@ -27,9 +27,6 @@ def __init__(self, app: App):
         # Create the visual representation of the document
         self.create()
 
-        # Create a platform specific implementation of the Document
-        self._impl = app.factory.Document(interface=self)
-
     ######################################################################
     # Document properties
     ######################################################################
@@ -80,7 +77,10 @@ def open(self, path: str | Path):
         :param path: The file to open.
         """
         self._path = Path(path).absolute()
-        self._impl.open()
+        if self._path.exists():
+            self.read()
+        else:
+            raise FileNotFoundError()
 
         # Set the title of the document window to match the path
         self._main_window.title = self._main_window._default_title

diff --git a/dummy/src/toga_dummy/documents.py b/dummy/src/toga_dummy/documents.py
diff --git a/dummy/src/toga_dummy/factory.py b/dummy/src/toga_dummy/factory.py
@@ -3,7 +3,6 @@
 from . import dialogs
 from .app import App, DocumentApp
 from .command import Command
-from .documents import Document
 from .fonts import Font
 from .hardware.camera import Camera
 from .hardware.location import Location
@@ -48,7 +47,6 @@ def not_implemented(feature):
     "App",
     "DocumentApp",
     "Command",
-    "Document",
     "Font",
     "Icon",
     "Image",

diff --git a/gtk/src/toga_gtk/documents.py b/gtk/src/toga_gtk/documents.py
diff --git a/gtk/src/toga_gtk/factory.py b/gtk/src/toga_gtk/factory.py
@@ -3,7 +3,6 @@
 from . import dialogs
 from .app import App
 from .command import Command
-from .documents import Document
 from .fonts import Font
 from .icons import Icon
 from .images import Image
@@ -42,7 +41,6 @@ def not_implemented(feature):
     "not_implemented",
     "App",
     "Command",
-    "Document",
     # Resources
     "Font",
     "Icon",

diff --git a/winforms/src/toga_winforms/documents.py b/winforms/src/toga_winforms/documents.py
diff --git a/winforms/src/toga_winforms/factory.py b/winforms/src/toga_winforms/factory.py
@@ -3,7 +3,6 @@
 from . import dialogs
 from .app import App
 from .command import Command
-from .documents import Document
 from .fonts import Font
 from .icons import Icon
 from .images import Image
@@ -42,7 +41,6 @@ def not_implemented(feature):
     "not_implemented",
     "App",
     "Command",
-    "Document",
     # Resources
     "Font",
     "Icon",