Restructure repository #1669
Restructure repository #1669
Conversation
| src/*/.tox | ||
| src/*/.coverage | ||
| src/*/.coverage.* |
There was a problem hiding this comment.
These 3 patterns are already listed above without any directory, so they don't need to be listed per-directory as well.
There was a problem hiding this comment.
Looks good - high churn, but mostly uncontroversial stuff. I saw a couple of minor docs issues and a missing file on the meta package which I've corrected.
I've also flagged two issues inline. One is "strong opinion, weakly held" (passing in --output building into a single /distfolder); the other is a "weak opinion, weakly held" (making tox -e package a package-level tox definition). I'm marking the PR as approved; I'm totally OK with this being merged without further changes, but if either of those points seem reasonable to you, I'd be OK with the change - and as long as CI still passes, a merge.
mhsmith
force-pushed
the
repo-structure
branch
from
e5fa757 to
594d2d4
Compare
Codecov Report
|
| - name: Extract ${{ matrix.package }} | ||
| run: | | ||
| mkdir dist | ||
| mv packages/$(echo ${{ matrix.package }} | sed 's/_/?/')-[0-9]* dist | ||
| mv */dist/$(echo ${{ matrix.package }} | sed 's/_/?/')-[0-9]* dist |
There was a problem hiding this comment.
I think there might be an analogous change missing from publish.rst?
There was a problem hiding this comment.
After discussion in person, turns out this isn't an issue on publish, because in the publish action, the artefact is coming from the GitHub Release, rather than the CI artefact,
| - name: Extract ${{ matrix.package }} | ||
| run: | | ||
| mkdir dist | ||
| mv packages/$(echo ${{ matrix.package }} | sed 's/_/?/')-[0-9]* dist | ||
| mv */dist/$(echo ${{ matrix.package }} | sed 's/_/?/')-[0-9]* dist |
There was a problem hiding this comment.
After discussion in person, turns out this isn't an issue on publish, because in the publish action, the artefact is coming from the GitHub Release, rather than the CI artefact,
Fixes #1627.
I've kept most of the mechanical changes in the first two commits, so you can exclude those to see the interesting stuff.
I've reviewed all appearances of "src" and "../" in the repository, so hopefully I haven't missed anything. But I haven't touched release.sh, because it's no longer being used by CI, and if we can move to setuptools-scm then it'll no longer have any use at all and can be removed.
PR Checklist: