Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Update pack.rst #1786

Merged
merged 3 commits into from
Feb 19, 2023
Merged

New Update pack.rst #1786

merged 3 commits into from
Feb 19, 2023

Conversation

proneon267
Copy link
Contributor

Added a note mentioning that the values should be passed as strings. Added missing font_style description and missing value of visibility.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267
Update pack.rst
c474e51 
Added a note mentioning that the values should be passed as strings.
Added missing ``font_style`` description and missing value of ``visibility``.
@proneon267 proneon267 changed the title Update pack.rst New Update pack.rst Feb 18, 2023
freakboy3742
freakboy3742 approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I've added the changenote that was causing CI to fail; I've also modified the note at the top of the page to use Sphinx-native markup.

@freakboy3742 freakboy3742 merged commit 69eb5c2 into beeware:main Feb 19, 2023
@proneon267
Copy link
Contributor Author

Thank you!

@mhsmith mhsmith mentioned this pull request Mar 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proneon267 @freakboy3742