Number input supports alignment #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.3.0...v3.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ted number logic to add number input in each box together and tell user not sum zero
freakboy3742
requested changes
Mar 21, 2023
examples/textinput/textinput/app.py
Outdated
| self.number_label.text = f"Double the number is: {number * 2}" | ||
| else: | ||
| self.number_label.text = "You didn't enter a number" | ||
| self.number_label.text = ( | ||
| "Pick some other numbers that won't add up to zero." |
There was a problem hiding this comment.
This is a misleading message, because that's not what you're testing with the if.
There was a problem hiding this comment.
How about "Pick some numbers that add up to more than zero"?
There was a problem hiding this comment.
I've updated the label to show Pick some numbers that add up to more than zero
freakboy3742
requested changes
Mar 22, 2023
examples/textinput/textinput/app.py
Outdated
| self.number_label.text = f"Double the number is: {number * 2}" | ||
| else: | ||
| self.number_label.text = "You didn't enter a number" | ||
| self.number_label.text = "Pick some numbers that add up to more than zero" |
There was a problem hiding this comment.
The old logic exited because number can be blank, which means addition and doubling won't work.
This new example will crash if either value doesn't exist. It would also make sense to report the sum of the two values, rather than double one of them.
There was a problem hiding this comment.
I've changed the logic completely to address this:
- label shows values for each box and sum
- added basic error handling for null values by displaying a warning to add a number to input box
freakboy3742
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented set_alignment & set_font for NumberInput
PR Checklist: