-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font loading for GTK backend #1846
Conversation
My preference would still be to use GI bindings for fontconfig; however it appears that they're woefully inadequate at present, so we have to work with what we have. |
Looks good to me - fonts are loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fonts load on my local system - thanks!
I'm going to close this in favor of #1903 - the latter incorporates all of this PR, but also includes tests, so it's a much better candidate for merging. |
Builds on the legwork done by @kiljoy001 and #1845; instead of vendoring the python-fontconfig library, and then using just 3 methods from it, this PR builds a ctypes binding for the 3 methods we need.
This design was discussed in Discord prior to python-fontconfig being considered, so there's no provenance/licensing issues.
With this PR, the
font
demo now works on Gtk.I have also converted the core font tests to pytest, and got them to 100% coverage. This PR doesn't include a test probe for live tests.
Refs #1837.
PR Checklist: