Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for set_full_screen in WinForms. #1863

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Added support for set_full_screen in WinForms. #1863

merged 7 commits into from
Apr 12, 2023

Conversation

proneon267
Copy link
Contributor

Added support for set_full_screen so that both enter_full_screen and exit_full_screen works in WinForms.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267
Copy link
Contributor Author

proneon267 commented Apr 11, 2023

I have changed back to is_full_screen instead of set_full_screen because of test error. But, I still think the argument should be named set_full_screen, since that's the condition that is being passed down from enter_full_screen and exit_full_screen.

Anyways, I have tested it locally. Works fine.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've extended your patch to add an example (which itself pointed out a minor bug on the macOS implementation).

I've also simplified the changenote. The change note generally shouldn't take about implementation specifics - it's a high level release note, so it should be framed in terms of talking about the benefits to the end user, rather detailing a specific API.

@freakboy3742 freakboy3742 merged commit 652abad into beeware:main Apr 12, 2023
@proneon267 proneon267 deleted the patch-1 branch April 12, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants