Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cursor visibility in WinForms. #1894

Merged
merged 6 commits into from
May 1, 2023

Conversation

proneon267
Copy link
Contributor

@proneon267 proneon267 commented Apr 24, 2023

Added support for cursor visibility in WinForms for the existing APIs. As discussed, implementation was done under existing API and no new API was added. A shadow variable was needed as the calls to show and hide cursor needs to be balanced.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267 proneon267 force-pushed the patch-8 branch 2 times, most recently from fdb300a to 76713a9 Compare April 25, 2023 01:51
@proneon267
Copy link
Contributor Author

@freakboy3742 Does this need some changes, or is it good?

@freakboy3742
Copy link
Member

This is on my list to look at; however, given the issues with #1895, I want to actually test this myself on Windows before merging, and I won't get a chance to do that until I'm back at work next week.

@proneon267
Copy link
Contributor Author

This is on my list to look at; however, given the issues with #1895, I want to actually test this myself on Windows before merging, and I won't get a chance to do that until I'm back at work next week.

Thanks. Take your time :)

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a manual test case, but otherwise this looks good.

@proneon267
Copy link
Contributor Author

I've added a manual test case, but otherwise this looks good.

Thanks :)

@freakboy3742 freakboy3742 merged commit 5a3d22c into beeware:main May 1, 2023
@proneon267 proneon267 deleted the patch-8 branch August 24, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants