Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressbar and switch widgets to web platform. #1901

Merged

Conversation

malikoth
Copy link
Contributor

@malikoth malikoth commented Apr 25, 2023

Add new widgets for the web platform:

  • ProgressBar
  • Switch

Also adds a pyodide import to toga_web.libs so we can use the create_proxy function to avoid having our proxies destroyed as seen here.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@malikoth malikoth marked this pull request as ready for review April 25, 2023 21:38
@malikoth
Copy link
Contributor Author

I think briefcase broke... The output of the CI / tesbed (linux) (pull_request) action does not look like it would have been caused by this change:

Run cd testbed
  cd testbed
  xvfb-run -a -s "-screen 0 2048x1536x24" briefcase run linux --test 
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    min_python_version: 3.7
    max_python_version: 3.11

[testbed] Finalizing application configuration...
Targeting ubuntu:jammy (Vendor base debian)

Log saved to /home/runner/work/toga/toga/testbed/logs/briefcase.2023_04_25-22_02_08.run.log


Traceback (most recent call last):
  File "/home/runner/.local/bin/briefcase", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.local/lib/python3.10/site-packages/briefcase/__main__.py", line 25, in main
    command(**options)
  File "/home/runner/.local/lib/python3.10/site-packages/briefcase/commands/run.py", line 273, in __call__
    self.finalize(app)
  File "/home/runner/.local/lib/python3.10/site-packages/briefcase/commands/base.py", line 529, in finalize
    self.finalize_app_config(app)
  File "/home/runner/.local/lib/python3.10/site-packages/briefcase/platforms/linux/system.py", line 161, in finalize_app_config
    if not self.use_docker:
AttributeError: 'LinuxSystemRunCommand' object has no attribute 'use_docker'
Error: Process completed with exit code 1.

@freakboy3742
Copy link
Member

Whelp... that CI failure is a bit of a mess - it's going to be related to beeware/briefcase#1222.

Signed-off-by: Kyle Rich <yutakafrog@gmail.com>
Signed-off-by: Kyle Rich <yutakafrog@gmail.com>
Signed-off-by: Kyle Rich <yutakafrog@gmail.com>
@malikoth malikoth force-pushed the add-web-progressbar-and-switch-widgets branch from ca81e59 to 1f2165d Compare April 26, 2023 15:16
Signed-off-by: Kyle Rich <yutakafrog@gmail.com>
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks!

@freakboy3742 freakboy3742 merged commit 0e8501c into beeware:main Apr 26, 2023
@malikoth malikoth deleted the add-web-progressbar-and-switch-widgets branch April 26, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants