Fixed bug related to missing_value for android and linux #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided for all headings and crashed on android for the same reason.
freakboy3742
reviewed
May 1, 2023
gtk/src/toga_gtk/widgets/tree.py
Outdated
| @@ -15,6 +15,7 @@ def create(self): | |||
| self.store = SourceTreeModel( | |||
| [{"type": str, "attr": a} for a in self.interface._accessors], | |||
| is_tree=is_tree, | |||
| missing_value=getattr(self.interface, "missing_value", None), | |||
There was a problem hiding this comment.
Why use getattr here? Unless I'm missing something, missing_value should always be defined on the interface.
There was a problem hiding this comment.
I am not at my computer to confirm fully but I believe the issue was the Tree interface did not have the missing_value. If you are able to look at the first round of checks it should show which interface did have it
There was a problem hiding this comment.
Ah - that makes sense. That's an API inconsistency that should probably be resolved...
freakboy3742
approved these changes
May 2, 2023
gtk/src/toga_gtk/widgets/tree.py
Outdated
| @@ -15,6 +15,7 @@ def create(self): | |||
| self.store = SourceTreeModel( | |||
| [{"type": str, "attr": a} for a in self.interface._accessors], | |||
| is_tree=is_tree, | |||
| missing_value=getattr(self.interface, "missing_value", None), | |||
There was a problem hiding this comment.
Ah - that makes sense. That's an API inconsistency that should probably be resolved...
freakboy3742
force-pushed
the
android_table_missing_value_#1879
branch
from
ff3186f to
a49ef11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For linux, I passed the missing_value from self.interface.missing_value from Tree to the sourcetreemodel. I did this because self.instance is not available inside the sourcetreemodel but the value is needed to be able to solve the bug.
For android, I simply added the self.interface.missing_value as the default option for the getattr.
On android the app will crash if values are not provided for all headings, on linux it will cause an error in the logs.
Fixes #1879
PR Checklist: