Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage cleanups #2004

Closed
wants to merge 4 commits into from
Closed

Conversation

freakboy3742
Copy link
Member

  • Restores 100% core test coverage for DateInput and TimeInput (caused by a missing code path in the deprecation shim)
  • Restores 100% cocoa test coverage for Button (caused by the recent change to interpret default widget height as NONE, rather than 0)
  • Ports the toga.platform tests to pytest. Not sure why, but the introduction of the NotImplmented factory shim in Improve error message when a platform doesn't support a widget. #1992 caused local pytest runs to fail for me. Tox runs were fine; but since we needed to update the tests anyway, now was as good a time as any. This also corrects a minor issue with the definition of current_platform, and gets the module to 100% test coverage.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742
Copy link
Member Author

Closed in favor of #2005

@freakboy3742 freakboy3742 deleted the cleanups branch June 26, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant