-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test undo/redo behaviour of text input widgets on macOS. #2151
Conversation
The cocoa MultilineTextInput widget has been updated to enable undo
This second try was easier. Previously, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I've dropped a couple of minor comments inline; once those are cleaned up, this should be good to land! Thanks!
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
A question of style: I am adding |
My personal preference is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks!
Widgets tested are:
The cocoa MultilineTextInput widget has been updated to enable undo.
Replaces PR #2037
PR Checklist: