Implemented Divider Widget on Android. #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One quick observation: if you're adding a new widget, you also need to update the support matrix: https://github.com/beeware/toga/blob/main/docs/reference/data/widgets_by_platform.csv |
|
Done. Thanks! |
freakboy3742
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Definitely does what it says :-)
The only question I have is whether TextView is the appropriate native widget for this. I know Android has a definite lean towards "every widget is a text input"... but it seems like overkill for a Divider which has no interactive component. In fact, the only thing this seems to be using the view for is rendering a 1px wide background. Could android.view.View be used instead?
|
Done. Using View seems to be more appropriate. Thanks! |
freakboy3742
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Android Divider widget. Additionally, I've enabled the Android divider test in the testbed and verified that this PR successfully passes it. Here's the example divider app:
With the audits complete, I will now focus on creating tests for #1930. I'm submitting this PR to avoid any potential loss of progress. Please review it at your convenience, no rush! 😊
PR Checklist: