Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android and WinForms rehint updates #2200

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Android and WinForms rehint updates #2200

merged 2 commits into from
Nov 6, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Nov 6, 2023

Updates from the review of #2186.

The best kind of PR – one that only removes code. 😄

@mhsmith mhsmith mentioned this pull request Nov 6, 2023
Merged
freakboy3742
freakboy3742 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm... if we delete all the code, we won't have any bugs! 🤔

Looks good, and now that I understand the rehint/refresh relationship, it all matches what I'd expect.

@freakboy3742 freakboy3742 merged commit bd042ae into beeware:main Nov 6, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsmith @freakboy3742