Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated invalid anchor section in webview download link in windows docs #2219

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Updated invalid anchor section in webview download link in windows docs #2219

merged 4 commits into from
Nov 12, 2023

Conversation

proneon267
Copy link
Contributor

@proneon267 proneon267 commented Nov 11, 2023 •
edited
Loading

Updated the anchor #download-section in link https://developer.microsoft.com/en-us/microsoft-edge/webview2/#download-section as it's invalid and causes the CI to fail.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267 proneon267 changed the title Removed invalid anchor section in webview Docs Removed invalid anchor section in webview download link in windows docs Nov 11, 2023
@HalfWhitt HalfWhitt mentioned this pull request Nov 12, 2023
Merged
4 tasks
freakboy3742
freakboy3742 requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right idea, wrong fix. The anchor still exists - it's just called #download now. We want to lead the user directly to the right section of the docs, so we should update the anchor, rather than removing it.

@proneon267
Copy link
Contributor Author

Done. Thanks!

@proneon267 proneon267 changed the title Removed invalid anchor section in webview download link in windows docs Updated invalid anchor section in webview download link in windows docs Nov 12, 2023
freakboy3742
freakboy3742 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I've made a small tweak to the release note - this is a minor administrative tweak, not something that requires a full notice about a bugfix.

@freakboy3742 freakboy3742 merged commit d6c5b03 into beeware:main Nov 12, 2023
35 checks passed
@proneon267 proneon267 deleted the windows_webview_docs_fix branch November 12, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proneon267 @freakboy3742