-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all development dependencies #2224
Conversation
db590a7
to
621bcfe
Compare
well....this is much more interesting now. pre-commit is failing on running this version of black in CI.... |
/me grumbles... Github will send me three emails to notify me that someone has commented on a PR, and will email me when I comment on a ticket, but won't email me when an automated process fails.... |
Was finally able to replicate locally....might have something to do with Python 3.12. Nonetheless, I looked at the file it was complaining about:
Given the top two lines, I switched the config to use the mirror and things seem to be working now.... |
FWIW, the "we" that is making this recommendation is apparently the maintainers of black....since this file comes from its repo: https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml |
ohhh....the version of pre-commit that Toga uses is 9 months old....I'm guessing Dependabot doesn't recursively look for setup.cfg files...???? or is something intentional going on here? |
Definitely nothing intentional; I can't explain why pre-commit isn't being updated. |
Dependabot isn't updating anything in https://github.com/beeware/toga/network/updates/748619508 I wonder if it's only checking |
Hrm - I wonder if this is a case of having setup.py confusing the setup - if we moved to a setup.cfg-only configuration, it wouldn't think that the configuration is in setup.py, and therefore miss that all the dependencies are in setup.cfg. |
Yep; I just duplicated the toga repo, deleted I'll just manually update everything in this PR for now to reset us. |
ab11218
to
7015a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't argue with CI success.
Changes
setup.cfg
andsetup.py
PR Checklist: