Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pinch-to-zoom in WebView on Android #2261

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

t-arn
Copy link
Contributor

@t-arn t-arn commented Dec 6, 2023

This PR adds the pinch-to-zoom feature in WebView for Android (see bug #2258)
The on-screen zoom controls are deactivated because they are deprecated.

It can be tested in the Android emulator with the webview example by pressing and holding the CTRL button and dragging the mouse.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@t-arn
Copy link
Contributor Author

t-arn commented Dec 6, 2023

@freakboy3742 Hello Russel, please review this PR.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing - thanks!

I can't think of any way to meaningfully test this in an automated manner, so I'm inclined to consider it a base configuration option of the webview.

@freakboy3742 freakboy3742 merged commit 2000b68 into beeware:main Dec 6, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants