Correct ImageView handling of flex=1 sizing #2276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2275.
The documentation for ImageView suggests that image should shrink if they're marked
flex=1
. However, the imposed size constraint ofat_least(size)
prevents shrinking.This PR changes the
at_least
constraints to all beat_least(0)
, which allows images to reduce in size in that axis. Any explicit or undeclared image size continues to be handled as before.PR Checklist: