Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the delay when waiting for map rendering updates. #2511

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

freakboy3742
Copy link
Member

Fixes #2509

Increases the delay when waiting for map rendering updates.

The test case passes consistently when run in slow mode; when running in fast mode, there's an appreciable "stutter" in rendering, which, depending on exact testing conditions, can result in a test failure. Increasing the delay gives the web view a little more time to complete rendering, which seems to avoid the problem.

Not sure why this suddenly started being a problem 2 days ago - my guess would be a change in how leaflet is deployed, but that's difficult to verify.

I've speculatively made the same change to the Winforms implementation, since it's using same underlying implementation.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith April 18, 2024 05:00
@mhsmith mhsmith merged commit 3228372 into beeware:main Apr 18, 2024
34 checks passed
@freakboy3742 freakboy3742 deleted the gtk-map-fix branch April 19, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux MapView zoom tests failing in CI
2 participants