Add content argument to MainWindow instantiation & Add Tests #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two of my checks failed. I haven't looked into them enough to know if I should change something. I hope to look into it more this weekend. |
|
The towncrier check is failing because your PR doesn't contain a changenote and the pre-commit check is failing because Black wants to make changes to updated files; more details are available here: https://beeware.org/contributing/how/process#code-style |
|
This has been superseded by #2586. |
|
Sorry for the confusion, it looks like two people somehow ended up working on this at the PyCon sprints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add content argument to MainWindow instantiation & Add Tests (made by cosmatech in PR #2314)
I've added a 'context' parameter to the init_ method of the Window and MainWindow classes, a doc string for each of those parameters, and added testing functions for this.
This simplifies the configuration of the context of the MainWindow.
Fixes #2307.
PR Checklist: