Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra android dependency #2595

Merged

Conversation

gwen-sarapata
Copy link
Contributor

This change allows Android builds to only need SwipeRefreshLayout when using DetailedList. DetailedList will not error if SwipeRefreshLayout is not installed, but will show an error to update dependencies if the widget is used without the import.

The SwipeRefreshLayout dependency was removed from the pyproject.toml on all examples files that do not use DetailedList.

This removes needing the dependency on every Android app, and can now only require the dependency when using the widget DetailedList.

This relates to the issue: Soften runtime requirement for Android SwipeRefreshLayout #2454

PR Checklist:

  • All new features have been tested -> features couldn't be tested with coverage (entered # pragma: no cover), but were tested with examples to ensure app works without the dependency and will show an error to add the dependency if DetailedList is used.
  • All new features have been documented -> added bullet about dependency to docs/reference/api/widgets/detailedlist.rst
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - the spelling issue looks like the only thing that needs to be fixed

changes/2454.feature.rst Outdated Show resolved Hide resolved
gwen-sarapata and others added 2 commits May 22, 2024 17:04
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

@freakboy3742 freakboy3742 merged commit 2bf76fe into beeware:main May 22, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants