Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new create package action with attestation #2604

Merged
merged 2 commits into from
May 30, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented May 27, 2024

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the attest-package branch 6 times, most recently from 8b21344 to 2fe9050 Compare May 27, 2024 21:39
@rmartin16 rmartin16 force-pushed the attest-package branch 3 times, most recently from a1efd23 to 3b97235 Compare May 27, 2024 23:05
@rmartin16
Copy link
Member Author

Toga has a unique complication the other repos didn't have. All of the other repos just include the sdist and wheel in the artifact....but Toga would replicate the internal filesystem structure of the repo such that the individual sdists and wheels were actually nested inside their respective subdirectory and dist dirs inside the artifact. Therefore, previously, when the artifacts were unpacked, the sdists and wheels would end up in dist directories inside the subdirectories. Now, all of the sdists and wheels are just unpacked in to a top-level dist directory since the new action couldn't replicate the old behavior. FWIW, the release/publish workflow had already implemented its own shenanigans to deal with this previously.

@rmartin16 rmartin16 marked this pull request as ready for review May 28, 2024 00:36
@rmartin16 rmartin16 force-pushed the attest-package branch 4 times, most recently from b68e5f0 to 56e9757 Compare May 28, 2024 21:03
@rmartin16
Copy link
Member Author

Testbed on macOS x86 is consistently failing....

https://github.com/beeware/toga/actions/runs/9277895431/job/25528491914?pr=2604

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit d68e9a8 into beeware:main May 30, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants