Limit toolbars to MainWindow instances, and allow for MainWindow menus. #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
freakboy3742
force-pushed
the
mainwindow-toolbar
branch
from
4258db5
to
63f122e
Compare
4 tasks
mhsmith
reviewed
Jun 18, 2024
mhsmith
reviewed
Jun 19, 2024
mhsmith
reviewed
Jun 19, 2024
mhsmith
reviewed
Jun 19, 2024
Co-authored-by: Malcolm Smith <smith@chaquo.com>
mhsmith
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2643; that PR should be reviewed and merged before reviewing this one.
Derived from #2244.
Modifies the handling of toolbars and menus, so that:
Inadvertently corrects a minor layout issue on GTK (I swear it's been reported, but I can't find the issue), where a MainWindow without any toolbar items has a small padding between the menubar and the toolbar. This was caused because an empty toolbar was still being included in the layout; this implementation only adds the toolbar if it has content.
PR Checklist: